Decorate: report annotation build errors instead of ignoring them - #1299
Open
nileshpatil6 wants to merge 1 commit into
Open
Decorate: report annotation build errors instead of ignoring them#1299nileshpatil6 wants to merge 1 commit into
nileshpatil6 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When
fx.Decorate(orfx.Replace, same path) receives anfx.Annotate(...)whose build fails, the error is silently discarded inrunDecorator:derris never assigned toerr, so the app starts cleanly,app.Err()is nil, and the decorator is simply never applied. Invokes receive the undecorated value with no diagnostic. The same build errors are surfaced normally when the annotated function goes throughfx.Provideorfx.Invoke.Example:
fx.Decorate(fx.Annotate(func(l *Logger) *Logger { ... }, fx.As(new(io.Reader))))where*Loggerdoes not implementio.Readerstarts the app successfully and hands invokes the original undecorated*Logger.The condition dates back to the original
fx.Decorateimplementation and this path had no test coverage.Change
Return the build error, matching how the other decorator paths report failures. Added a regression test in
TestDecorateFailureand a CHANGELOG entry.The new test fails on master with "An error is expected but got nil" and passes with the change. Full test suite passes.